extend:webhook-deliveries #364
Conversation
There was a problem hiding this comment.
Hi there 👋
Thanks for your contribution!
We will need to keep the functionality were the webhook subscription is either created or updated, and we will need to use the getMutationName so that we call the correct mutation based on the type of subscription we are creating (pubsub, http ect).
We should also update the tests to include these new parameters.
|
Should be good now, also updated php-docs @lizkenyon |
|
@admirsaheta You will need to update the tests for the register method now that we have changed the request to create the subscriptions. |
|
Not really well-versed with tests, would appreciate co-authoring here. :) |
src/Webhooks/DeliveryMethod.php
Outdated
| $fieldsQuery = !empty($fields) ? 'fields: [' . implode(',', $fields) . ']' : ''; | ||
| $metafieldNamespacesQuery = !empty($metafieldNamespaces) ? 'metafieldNamespaces: [' . implode(',', $metafieldNamespaces) . ']' : ''; | ||
|
|
||
| // Assemble the webhook subscription arguments | ||
| $webhookSubscriptionArgs = $this->queryEndpoint($callbackAddress); |
There was a problem hiding this comment.
We need to use this method to properly build the callback URL, for each of the webhook cases Pubsub, HTTP, eventbridge.
To run the tests you can run |
…tafield namespaces
|
"I have signed the CLA!" |
WHY are these changes introduced?
Fixes #362
This pull request addresses the lack of support for specifying fields and metafieldNamespaces in webhook registrations.
The feature aligns with the Ruby implementation by allowing more granular control over which fields and metafields are included
in the webhook payload.
WHAT is this pull request doing?
fieldsandmetafieldNamespacesin thebuildRegisterQuerymethod of theRegistryclass.buildRegisterQuerymethod to construct GraphQL mutations with these new parameters.Type of change
Checklist